Skip to content

fix: replace unsafe zeroed() with MaybeUninit in split_at #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crStiv wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: replace unsafe zeroed() with MaybeUninit in split_at #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a64913a
Update iterable_field.rs
crStiv Nov 7, 2025
65e64ea
Update par_iter.rs
crStiv Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions crates/air-utils-derive/src/iterable_field.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,15 +260,15 @@ impl IterableField {
let tail = format_ident!("{}_tail", name);
let array_size = &array_of_vecs.outer_array_size;
quote! {
let (
mut #head,
mut #tail
):([_; #array_size],[_; #array_size]) = unsafe { (std::mem::zeroed(), std::mem::zeroed()) };
let mut #head: [std::mem::MaybeUninit<_>; #array_size] = unsafe { std::mem::MaybeUninit::uninit().assume_init() };
let mut #tail: [std::mem::MaybeUninit<_>; #array_size] = unsafe { std::mem::MaybeUninit::uninit().assume_init() };
self.#name.into_iter().enumerate().for_each(|(i, v)| {
let (head, tail) = v.split_at_mut(#index);
#head[i] = head;
#tail[i] = tail;
let (head_val, tail_val) = v.split_at_mut(#index);
#head[i].write(head_val);
#tail[i].write(tail_val);
});
let #head = unsafe { std::mem::MaybeUninit::array_assume_init(#head) };
let #tail = unsafe { std::mem::MaybeUninit::array_assume_init(#tail) };
}
}
}
Expand Down
1 change: 0 additions & 1 deletion crates/air-utils-derive/src/par_iter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ fn generate_row_producer(
type Item = #mut_chunk_name<#lifetime>;
type IntoIter = #iter_mut_name<#lifetime>;

#[allow(invalid_value)]
fn split_at(self, index: usize) -> (Self, Self) {
#(#split_at)*
(
Expand Down