Skip to content

Implement fri jumps for SIMD.#1340

Open
leo-starkware wants to merge 1 commit intodevfrom
leo/fri_jumps_simd
Open

Implement fri jumps for SIMD.#1340
leo-starkware wants to merge 1 commit intodevfrom
leo/fri_jumps_simd

Conversation

@leo-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@leo-starkware leo-starkware marked this pull request as ready for review February 25, 2026 12:08
Copy link
Contributor

@alon-f alon-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alon-f made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on ilyalesokhin-starkware and leo-starkware).


crates/stwo/src/prover/backend/simd/fri.rs line 53 at r1 (raw file):

        let mut folding_alpha = alpha;
        for _ in 0..fold_step {
            alphas.push(folding_alpha);

Why not prepare the alphas in advance?

Code quote:

alphas.push(folding_alpha);

Copy link
Contributor

@alon-f alon-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alon-f made 1 comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on ilyalesokhin-starkware and leo-starkware).


crates/stwo/src/prover/backend/simd/fri.rs line 58 at r1 (raw file):

        let domain = eval.domain();
        let all_twiddles = domain_line_twiddles_from_tree(domain, &twiddles.itwiddles);

and why is this needed here and not taken from the precomputed twiddles?

Code quote:

        let all_twiddles = domain_line_twiddles_from_tree(domain, &twiddles.itwiddles);

@leo-starkware leo-starkware requested a review from alon-f February 26, 2026 16:03
Copy link
Contributor Author

@leo-starkware leo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leo-starkware made 2 comments.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on alon-f and ilyalesokhin-starkware).


crates/stwo/src/prover/backend/simd/fri.rs line 53 at r1 (raw file):

Previously, alon-f wrote…

Why not prepare the alphas in advance?

where?


crates/stwo/src/prover/backend/simd/fri.rs line 58 at r1 (raw file):

Previously, alon-f wrote…

and why is this needed here and not taken from the precomputed twiddles?

it is taken from the precomputed twiddles, this is just a reshaping function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants