Conversation
59ec26e to
50a6498
Compare
alon-f
left a comment
There was a problem hiding this comment.
@alon-f made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on ilyalesokhin-starkware and leo-starkware).
crates/stwo/src/prover/backend/simd/fri.rs line 53 at r1 (raw file):
let mut folding_alpha = alpha; for _ in 0..fold_step { alphas.push(folding_alpha);
Why not prepare the alphas in advance?
Code quote:
alphas.push(folding_alpha);
alon-f
left a comment
There was a problem hiding this comment.
@alon-f made 1 comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on ilyalesokhin-starkware and leo-starkware).
crates/stwo/src/prover/backend/simd/fri.rs line 58 at r1 (raw file):
let domain = eval.domain(); let all_twiddles = domain_line_twiddles_from_tree(domain, &twiddles.itwiddles);
and why is this needed here and not taken from the precomputed twiddles?
Code quote:
let all_twiddles = domain_line_twiddles_from_tree(domain, &twiddles.itwiddles);
leo-starkware
left a comment
There was a problem hiding this comment.
@leo-starkware made 2 comments.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on alon-f and ilyalesokhin-starkware).
crates/stwo/src/prover/backend/simd/fri.rs line 53 at r1 (raw file):
Previously, alon-f wrote…
Why not prepare the alphas in advance?
where?
crates/stwo/src/prover/backend/simd/fri.rs line 58 at r1 (raw file):
Previously, alon-f wrote…
and why is this needed here and not taken from the precomputed twiddles?
it is taken from the precomputed twiddles, this is just a reshaping function
No description provided.