Use BaseColumnPool in CommitmentSchemeProver::commit to avoid allocation during polynomial evaluation.#1342
Open
ilyalesokhin-starkware wants to merge 1 commit intodevfrom
Open
Use BaseColumnPool in CommitmentSchemeProver::commit to avoid allocation during polynomial evaluation.#1342ilyalesokhin-starkware wants to merge 1 commit intodevfrom
ilyalesokhin-starkware wants to merge 1 commit intodevfrom
Conversation
|
This change is |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ilyalesokhin-starkware
changed the base branch from
ilya/mem_pool1
to
graphite-base/1342
ilyalesokhin-starkware
force-pushed
the
graphite-base/1342
branch
from
5675eab to
9593293
Compare
ilyalesokhin-starkware
force-pushed
the
ilya/mem_pool2
branch
from
a2f1b05 to
4351631
Compare
ilyalesokhin-starkware
changed the base branch from
graphite-base/1342
to
dev
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #1342 +/- ##
==========================================
- Coverage 91.94% 91.69% -0.25%
==========================================
Files 121 122 +1
Lines 15324 15419 +95
Branches 15324 15419 +95
==========================================
+ Hits 14090 14139 +49
- Misses 1140 1185 +45
- Partials 94 95 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ilyalesokhin-starkware
force-pushed
the
ilya/mem_pool2
branch
from
4351631 to
fa1c66d
Compare
ilyalesokhin-starkware
force-pushed
the
ilya/mem_pool2
branch
2 times, most recently
from
0ee003a to
c8e2ac3
Compare
…ion during polynomial evaluation. Add BaseColumnPool for Col<B, BaseField> buffers, add evaluate_into to PolyOps trait (CPU and SIMD backends), and thread the pool through commit → CommitmentTreeProver::new → evaluate_polynomials. Buffers are pre-taken before parallel iteration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ilyalesokhin-starkware
force-pushed
the
ilya/mem_pool2
branch
from
c8e2ac3 to
7157213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BaseColumnPool for Col<B, BaseField> buffers, add evaluate_into to PolyOps trait
(CPU and SIMD backends), and thread the pool through commit → CommitmentTreeProver::new
→ evaluate_polynomials. Buffers are pre-taken before parallel iteration.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com