Skip to content

[hrpsys_ros_bridge] chage RTC name of RangeROSBridge and PointCloudROSBridge#1059

Open
YoheiKakiuchi wants to merge 3 commits intostart-jsk:masterfrom
YoheiKakiuchi:fix_rtc_name2
Open

[hrpsys_ros_bridge] chage RTC name of RangeROSBridge and PointCloudROSBridge#1059
YoheiKakiuchi wants to merge 3 commits intostart-jsk:masterfrom
YoheiKakiuchi:fix_rtc_name2

Conversation

@YoheiKakiuchi
Copy link
Member

@YoheiKakiuchi YoheiKakiuchi commented Jan 21, 2019

Currently name of RangeROSBridge component is RangeROSBridge0.rtc.
By this PR, the name of component is the same name as ROS nodename.

@YoheiKakiuchi YoheiKakiuchi force-pushed the fix_rtc_name2 branch 2 times, most recently from 832d0e6 to 8ca178f Compare January 30, 2019 09:34
@YoheiKakiuchi YoheiKakiuchi requested a review from k-okada January 31, 2019 04:22
@YoheiKakiuchi YoheiKakiuchi requested a review from mmurooka March 14, 2019 06:33
mmurooka
mmurooka reviewed Mar 22, 2019
View reviewed changes
Copy link
Member

@mmurooka mmurooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this PR, the name of component is the same name as ROS nodename.

I haven't use this component, and I'm not familiar with it.
Could you explain why it is necessary, please?

k-okada
k-okada approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@k-okada k-okada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think component name can be changed by arguments
https://github.com/tork-a/rtmros_nextage/blob/indigo-devel/nextage_ros_bridge/launch/nextage_ros_bridge_simulation.launch#L27

@YoheiKakiuchi
Copy link
Member Author

YoheiKakiuchi commented Mar 22, 2019

These components work for converting point cloud/lidar message from OpenRTM to ROS.
For the current implementation, RTC name of these components is PointCluoudRosBridge0, PointCluoudRosBridge1 ..., like that.
It is difficult to use if there are several components.

By this PR, RTC name is set as the same of ROS nodename.
So, we can change RTC name which is understandable, such as HEAD_DEPTH, FRONT_LIDER etc.
ImageSensorRosBridge does the same behavior as this PR.

mmurooka
mmurooka approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@mmurooka mmurooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explanation. In which robot or environment, does this rtc used? In choreonoid simulation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-okada k-okada k-okada approved these changes

@mmurooka mmurooka mmurooka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YoheiKakiuchi @k-okada @mmurooka