[rtmbuild] fix include/link path for openhrp3 (by ishiguroJSK)#1106
Merged
k-okada merged 2 commits intostart-jsk:masterfrom Dec 23, 2021
Merged
[rtmbuild] fix include/link path for openhrp3 (by ishiguroJSK)#1106k-okada merged 2 commits intostart-jsk:masterfrom
k-okada merged 2 commits intostart-jsk:masterfrom
Conversation
Utaro-M
approved these changes
May 26, 2021
Member
Utaro-M
left a comment
Utaro-M
left a comment
There was a problem hiding this comment.
openhrp3をsourceで入れたtablisのubuntu16制御PCでWait for localhost:15005/HrpsysSeqStateROSBridge0.rtc:rsangle が出続ける問題が解決することを自分のワークスペースで確認しました。
masterのjaxonredのchoreonoidが立ち上がることも確認し副作用がないことを確認しました。
Contributor
Author
|
お手すきの時にmergeしていただけますと幸いです． |
Closed
Contributor
Author
|
@k-okada これがないと、Ubuntu16の実機が起動しません. 問題が無ければmergeをお願いします。 |
Contributor
Author
|
ありがとうございます |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1064 (comment) のコメントに書いてある修正点です．
#1104 から抽出しました．
openhrp3をソースから入れた時にchoreonoidや実機rosbridgeが立ち上がらない問題を回避するための変更です．
rtmbuildパッケージのcmakeファイル内のpathの順序を， #1062 で述べられているバグの発生条件を回避するように変更します.
自分のkinetic環境だと，この変更がないとopenhrp3をソースから入れた時にchoreononidでシミュレーションができませんでした.