No tests will block the configuration step#1126
Open
kazuki0824 wants to merge 4 commits intostart-jsk:masterfrom
Open
No tests will block the configuration step#1126kazuki0824 wants to merge 4 commits intostart-jsk:masterfrom
kazuki0824 wants to merge 4 commits intostart-jsk:masterfrom
Conversation
Add checking the condiition where testing is really enabled or not
kazuki0824
added a commit
to kazuki0824/hlab-nxo-setup
that referenced
this pull request
Aug 6, 2022
Add checking the condiition where testing is really enabled or not
Collaborator
|
@kazuki0824 835a711 seems not good workaround, because the problem is caused by a bug of collada_urdf and will be fixed by ros/collada_urdf#44 or ros/collada_urdf#46. |
Author
kazuki0824
added a commit
to kazuki0824/hlab-nxo-setup
that referenced
this pull request
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
If CATKIN_ENABLE_TESTING is set to
OFF, configuration fails innoetic.catlkin b openrtm_tools --summarize --cmake-args -DCATKIN_ENABLE_TESTING=OFF
This patch has
This PR adds checking the condiition where testing is really enabled or not.