-
-
Notifications
You must be signed in to change notification settings - Fork 495
feat(AlgoliaAPI): add endowment parsing and unit conversion #2619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AlgoliaAPI): add endowment parsing and unit conversion #2619
Conversation
|
Having looked at this more, I don't think you need the separate function and could attempt to get the endowment attribute in the same way that ethnicity is attempted, and then assign performer["penis_length"] with the feet_to_cm converted value, i.e. just two lines. You shouldn't have to include the gender in the condition either, and can assume that any actor with an endowment attribute populated is referring to their penis length. I can't think what else endowment would be measuring. |
adee31a to
50599d9
Compare
|
Updated and rebased |
nrg101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but can you provide one or two examples so I can test each conversion taking place?
|
…rmer height and weight Signed-off-by: xantror <[email protected]>
Signed-off-by: xantror <[email protected]>
cf29e25 to
b98a099
Compare
|
Merge after #2627 |
4deb5fa to
b98a099
Compare
|
Thanks! |
This PR adds endowment field parsing and unit conversion for performer height/weight into
AlgoliaAPI.I'm not sure if some sites that use this already have metric values for height/weight or if endowment is limited to
penis_sizeor if it is used differently for females so additional input is welcome.I tried spot checking with some of the scrapers that used this but all the performers I tried to test had no weight/height/endowment values - needs additional testing.
The only site i managed to test is
chaosmen.comwhere it functions as expected.