feat(Clips4Sale): reimplement Clips4Sale scraper in python #2631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xantror <[email protected]>
Signed-off-by: xantror <[email protected]>
…base64 options Signed-off-by: xantror <[email protected]>
Signed-off-by: xantror <[email protected]>
xantror
force-pushed
the
xantror/update-clips4sale
branch
from
45d9baf to
00ff0c0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
feederbox826
requested changes
Dec 30, 2025
Collaborator
feederbox826
left a comment
feederbox826
left a comment
There was a problem hiding this comment.
A lot of really odd and inconsistent style choices
| text = str(text) | ||
| # Unescape HTML entities first (e.g. <br> -> <br>) | ||
| text = html.unescape(text) | ||
| text = re.sub(r'data-\w+="[^"]*"\s*', "", text) |
Collaborator
There was a problem hiding this comment.
why strip data attributes if you're just going to get_text()?
| url = f"https://www.clips4sale.com/studio/{studio_id}/{studio_slug}?_data=routes%2F%28%24lang%29.studio.%24id_.%24studioSlug.%24" | ||
| try: | ||
| response = scraper.get(url) | ||
| if response.status_code == 200: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if response.status_code == 200: | |
| if response.ok: |
| url = f"https://www.clips4sale.com/performers/{performer_id}/{encoded_slug}?_data=routes%2F%28%24lang%29.performers.%24performerId.%28%24performerSlug%29" | ||
| try: | ||
| response = scraper.get(url) | ||
| if response.status_code == 200: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if response.status_code == 200: | |
| if response.ok: |
| if p_tags := p_data.get("tags"): | ||
| performer["tags"] = p_tags | ||
| else: | ||
| performer["urls"] = [performer_url] |
Collaborator
There was a problem hiding this comment.
performer[urls] is in both conditions, why nest it?
| if lower not in unique_tags: | ||
| unique_tags[lower] = original | ||
| else: | ||
| # Prefer the version with more uppercase letters |
| res["tags"] = tags | ||
| if performers: | ||
| res["performers"] = performers | ||
| return res |
Collaborator
There was a problem hiding this comment.
why switch up nullish check style? stash handles it just fine if it's given NoneType
| if details := clean_text(dig(clip, "description")): | ||
| scene["details"] = details | ||
|
|
||
| scene["studio"] = studio_obj |
Collaborator
There was a problem hiding this comment.
see comment above on nullish typings
| log.debug(f"Searching URL: {url}") | ||
| try: | ||
| response = scraper.get(url) | ||
| if response.status_code != 200: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if response.status_code != 200: | |
| if not response.ok: |
|
|
||
| try: | ||
| response = scraper.get(data_url) | ||
| if response.status_code == 200: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if response.status_code == 200: | |
| if response.ok: |
| log.debug(f"Searching Performer URL: {url}") | ||
| try: | ||
| response = scraper.get(url) | ||
| if response.status_code != 200: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if response.status_code != 200: | |
| if not response.ok: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scraper type(s)
Short description
Merge after: #2628