Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm
Stash was switch to pnpm with stashapp/stash#6186, it's about time we caught up.
dependencies were also updated to close out dependabot #2677 and #2667
deno
chalk v6 is now a pure ESM module, this required a rewrite from CommonJS to ESM, hence the .mjs extension change as well.
Since validator is only expected to be ran as a one-off or used sparingly, deno was chosen to be able to run it without any dependency management, since we are on pretty stable versioning. This also makes the docker validate much easier to run with, it's faster and more secure for something that requires a very limited scope. Without cache, it is faster than the previous pnpm process by ~7 seconds
It was a crazy experiment, this was just the perfect candidate and it is performing amazingly