[8.x] Only add getRouteKeyName to models when collection uses slugs#677
Merged
duncanmcclean merged 1 commit into8.xfrom Mar 31, 2025
Merged
[8.x] Only add getRouteKeyName to models when collection uses slugs#677duncanmcclean merged 1 commit into8.xfrom
getRouteKeyName to models when collection uses slugs#677duncanmcclean merged 1 commit into8.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the collection importer, where the
getRouteKeyNamemethod would be added to Eloquent models, even when the slugs weren't enabled on the source collection.This would cause a 404 when viewing models in the Control Panel.
Related: #675 (comment)