[8.x] Fix error when serializing resources with appended attributes#686
Merged
duncanmcclean merged 1 commit into8.xfrom May 14, 2025
Merged
[8.x] Fix error when serializing resources with appended attributes#686duncanmcclean merged 1 commit into8.xfrom
duncanmcclean merged 1 commit into8.xfrom
Conversation
|
Released as part of v8.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an error when attempting to serialize Runway's
Resourceobject, which ultimately attempts to serialize a fresh instance of the Eloquent model.However, since it serialises the fresh instance of the Eloquent model, no attributes are set, so model accessors using the
$attributesparameter error out:To prevent an error when serializing appended attributes on a fresh model, we're now simply returning the model's class name, rather than calling its
toArray()method.Fixes #685.