[8.x] Fix runway search on models with individual connections #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently ran into an issue where the search on our Runway models was not working properly (as in it wasn't filtering at all): https://discord.com/channels/489818810157891584/1151898550305837086/1415710334219583518
After a bit of digging, I found out that it is because we are using the Orbit Eloquent driver for the model, and Orbit specifies the DB connection on a per model basis. This means that when this code is called for scoping the Runway search:
it gets the default DB connection and not the Orbit connection.
This is not an Orbit specific issue as this behavior would happen with any model that specifies a different DB connection than the default.
This PR adds a failing test and a simple fix to use the model's connection and subsequently schema builder to check for the columns' existence.