Skip to content

[9.x] Run tests on Windows #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duncanmcclean merged 4 commits into from
Jan 21, 2026
Merged

[9.x] Run tests on Windows #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1a50b9
Reduce the number of extensions we install
duncanmcclean Jan 21, 2026
c86d5e5
Add Windows to testing matrix
duncanmcclean Jan 21, 2026
2c07dcc
Merge branch 'master' into windows-tests
duncanmcclean Jan 21, 2026
78dce7e
trim whitespace
duncanmcclean Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,13 @@ jobs:
laravel: [12.*]
stability: [prefer-lowest, prefer-stable]
os: [ubuntu-latest]
include:
- os: windows-latest
php: 8.5
laravel: 12.*
stability: prefer-stable

name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }}
name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}

steps:
- name: Checkout code
Expand All @@ -30,7 +35,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, soap, intl, gd, exif, iconv, imagick
extensions: fileinfo, exif, gd, pdo, sqlite, pdo_sqlite, intl

- name: Install dependencies
run: |
Expand Down
3 changes: 1 addition & 2 deletions tests/Http/Controllers/ApiControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,7 @@ public function gets_a_resource_model_with_nested_fields()
->assertSee(['data'])
->assertJsonPath('data.id', $post->id)
->assertJsonPath('data.values.alt_title', 'Alternative Title...')
->assertJsonPath('data.values.alt_body', '<p>This is a <strong>great</strong> post! You should <em>read</em> it.</p>
');
->assertJsonPath('data.values.alt_body', fn ($value) => trim($value) === '<p>This is a <strong>great</strong> post! You should <em>read</em> it.</p>');
}

#[Test]
Expand Down