[6.x] Prevent variable conflicts with wildcard tags#11611
Merged
jasonvarga merged 5 commits intomasterfrom Mar 24, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when you do something like this in your template:
{{ nav:footer }} <!-- --> {{ /nav:footer }}Statamic will check if a
footervariable exists in the tag's context and use its value, otherwise it'll fallback to the literal string,footer.This behaviour is a little problematic, for example if you have a global called
footer, but you also have a nav calledfooter. It would end up passing your augmented global as the handle for the nav, which obviously won't work.This issue only affects a couple of our tags:
{{ session }}{{ cookie }}{{ nav }}{{ redirect }}We're doing similar things in the
{{ dump }},{{ asset }},{{ get_content }}and{{ glide }}tags but the behaviour makes sense in those cases.Fixes #10612
Fixes #10643