[6.x] Fix chunked queries not honoring user-defined limits and offsets #11701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the
->chunk()method on our query builder ignores any user-defined limits and offsets.This meant that the following query would give you 10 chunks of 5 entries, rather than 2 chunks of 5 entries:
This was fixed in Laravel 12, so I've copied over the fix (and the related test cases) in this PR. The Laravel PR has more context around the issue, and the fix.
Since this introduces a change in behaviour, this pull request is targeting the
masterbranch.Fixes #11698.