[6.x] Remove push on blur for combobox tags #13117
Closed
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushing on blur has some side effects, for example if you're in middle of typing in a tags fieldtype, then switch to a different browser tab, whatever tag you're in the middle of typing will be submitted
jasonvarga
requested changes
Nov 21, 2025
Member
jasonvarga
left a comment
jasonvarga
left a comment
There was a problem hiding this comment.
When using combobox with multiple="false" (like a select fieldtype) it's really unclear whether your value has been accepted or not when blurring.
When you blur on multiple, your input disappears.
When you blur on single, your input stays there.
…ccepted (on both single and multiple select options) so it's clearer whether your value has been accepted or not when blurring.
Author
|
I think this behaviour is actually the same on |
Member
|
I'm a bit confused about what's happening here. Now when you have a Let's leave this alone for now, and once Storybook is ready, we can make some tests to handle all the cases a bit better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing tags on blur has some side effects; for example, if you're in a tag fieldtype and in the middle of typing a tag, then switch to a different browser tab, whatever tag you're typing will be submitted.
So this is undesirable behaviour, unless it's needed.