[6.x] Fix JsDriver::addToFormData call to match interface signature #13473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method $jsDriver->addToFormData() was being called with two arguments ($form, $data), while the JsDriver interface defines it to accept only one parameter: public function addToFormData($data).
Contributor
Author
|
@jasonvarga Thanks for merging previous PR. here are the same for 6.x |
Member
|
No need for a second PR. We'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
$jsDriver->addToFormData()was being called with two arguments($form, $data), while the JsDriver interface defines it to accept only one parameter:This commit aligns the method call with the interface contract, preventing signature mismatch and potential runtime errors.
PR similar to PR [5.x]