[6.x] Avoid squashed Combobox options near viewport edge (attempt #2) #13489
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reka relies on the `min-height` property to determine when it needs to flip the options. A single option is 2.5 rem high, so we need different min heights to avoid whitespace on selects with 1/2 options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings back #13452, but uses different
min-heightvalues depending on the number of options to avoid the awkward whitespace issue seen in #13461.Reka relies on the
min-heightproperty to determine when it needs to flip the options.Fixes #13365
Before
CleanShot.2026-01-09.at.11.06.45.mp4
After
CleanShot.2026-01-09.at.11.05.09.mp4