[6.x] Don't redirect to referrer when 2FA challenge is required #13491
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
requested changes
Jan 9, 2026
Member
jasonvarga
left a comment
jasonvarga
left a comment
There was a problem hiding this comment.
This breaks regular logins. You get inertia-redirected to the dashboard but we don't want that. We want a full redirect since once inside the cp more stuff is needed to be initialized.
duncanmcclean
changed the title
Member
Author
|
Ahhh, so it does. Just pushed up a slightly different approach, let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue when logging in with 2FA where you'd be redirected to the 2FA challenge back, then immediately back to the login page.
This was due to us always redirecting to the referrer URL. I've added a conditional before redirecting to check if a 2FA challenge is required.