Skip to content

[6.x] Grid dot menu improvements #13500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 4 commits into from
Jan 13, 2026
+3 −2
Merged

[6.x] Grid dot menu improvements #13500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f82bac
Hide the dot menu until hovered
JayGeorge Jan 9, 2026
6f44a19
Make asset grid dot menus opaque
JayGeorge Jan 9, 2026
95f9bdb
Make the dots accessible to focus
JayGeorge Jan 12, 2026
7638121
Add button to focus states to override webkit's focus ring
JayGeorge Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion resources/css/elements/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
@layer base {
/* Explicitly show focus without needing to tab */
.show-focus:focus,
button,
/* Explicitly show focus without needing to tab for buttons inside modals, e.g. Assets > cancel button on delete modal */
[data-dismissable-layer] button:focus,
/* and then a global selector for focus-visible everywhere else (except where the focus-within class will handle the focus outline target instead). Use a direct descendant here so we don't affect things like the focus state of Bard field > Replicator > then another Bard field. */
Expand Down Expand Up @@ -70,7 +71,7 @@
}

/* Notes...

- Sometimes we want to show a focus outline on a container when it has focus-within, e.g. in Replicator sets where we want to show a focus outline on the set header when it has focus on the button inside the header, whose shape is not as neat.

- Here we set a specific target for the focus outline
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/assets/Browser/Grid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
</div>
</div>
</button>
<div class="absolute end-2 top-1">
<div class="absolute end-1 top-1 opacity-0 group-hover:opacity-100 group-focus-within:opacity-100 transition-opacity [&_button]:bg-white [&_button]:hover:bg-white [&_button]:dark:bg-gray-900 [&_button]:dark:hover:bg-gray-900">
<Dropdown placement="left-start">
<DropdownMenu>
<DropdownItem
Expand Down