[6.x] Asset tile and checkerboard improvements #13502
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re the border meant that previously the checkerbox would overlap it by 1px
… looks rubbish if it's the default inset
…causes a visual shift.
…setting the focus outline and I don't think it's needed anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor improvements to asset tiles…
Checkerboard Colour for Dark Mode
The checkerboard is now black for dark mode rather than a blue hue. This is clearer and more in keeping with the dark theme.
Before
After
Checkerboard Clipping
I noticed you could trigger a glitchy-looking focus outline in some instances—e.g. if you opened the assets modal then escaped it. This is due to the tile receiving both the hover checkerboard state and the natural focus state. The checkerboard position is in front of the focus ring, so it clips it whenever there's a gray square.
Before
Notice the clipping border surrounding the checkerboard for the selected item.
After
Instead, we've shifted the focus outline slightly for asset tiles. The selection state remains, but it's slightly exaggerated when it has keyboard focus.