Merged
Conversation
jasonvarga
requested changes
Jan 15, 2026
Member
jasonvarga
left a comment
There was a problem hiding this comment.
I'd rather enforce 5.3 when it's out (or require the 5.3.x branch now) and expect CredentialRecord all over.
Technically a breaking change, but we're still in beta and all this is a brand new thing to v6. We can call it a bug fix and plead to the semver gods.
pretty pls don't hate me semver overlords
Member
Author
|
I've updated this PR to require the 5.3.x branch instead and removed the backwards compatibility fix. |
jasonvarga
added a commit
that referenced
this pull request
Jan 25, 2026
This reverts commit 2162e04.
jasonvarga
added a commit
that referenced
this pull request
Jan 26, 2026
Fix creating passkeys (#13566)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue preventing passkeys from being created.
Problem
The
web-auth/webauthn-libpackage recently changed what is returned by theassertionResponseValidator->check()method.It previously returned a
PublicKeyCredentialSourceinstance but it now returns aCredentialRecordinstance, causing a type error in our code.Solution
This PR fixes it by accepting any object (as
CredentialRecordonly exists in5.3.x) and converting theCredentialRecordto what we're expecting.These changes are part of the package's
5.3.xbranch which is yet to be tagged, but seems to be used when creating new Statamic sites.An alternative solution would be to pin the package to
5.2.xand handle the necessary changes after5.3.xhas been tagged.Fixes #13561