Skip to content

Conversation

@duncanmcclean
Copy link
Member

This pull request fixes an issue preventing passkeys from being created.

Problem

The web-auth/webauthn-lib package recently changed what is returned by the assertionResponseValidator->check() method.

It previously returned a PublicKeyCredentialSource instance but it now returns a CredentialRecord instance, causing a type error in our code.

Solution

This PR fixes it by accepting any object (as CredentialRecord only exists in 5.3.x) and converting the CredentialRecord to what we're expecting.

These changes are part of the package's 5.3.x branch which is yet to be tagged, but seems to be used when creating new Statamic sites.

An alternative solution would be to pin the package to 5.2.x and handle the necessary changes after 5.3.x has been tagged.


Fixes #13561

@duncanmcclean duncanmcclean linked an issue Jan 15, 2026 that may be closed by this pull request
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather enforce 5.3 when it's out (or require the 5.3.x branch now) and expect CredentialRecord all over.
Technically a breaking change, but we're still in beta and all this is a brand new thing to v6. We can call it a bug fix and plead to the semver gods.

@duncanmcclean
Copy link
Member Author

duncanmcclean commented Jan 15, 2026

I've updated this PR to require the 5.3.x branch instead and removed the backwards compatibility fix.

@jasonvarga jasonvarga merged commit 2162e04 into master Jan 15, 2026
11 checks passed
@jasonvarga jasonvarga deleted the webauthn-credentials branch January 15, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[6.x] Cannot create passkey

3 participants