Skip to content

[6.x] Fix CodeEditor previews in Storybook #13588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 3 commits into from
Jan 16, 2026
+5 −8
Merged

[6.x] Fix CodeEditor previews in Storybook #13588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc09f5e
uncomment docs
duncanmcclean Jan 16, 2026
a8a71c2
import codemirror css
duncanmcclean Jan 16, 2026
4771cb8
disable mode selection in example
duncanmcclean Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .storybook/storybook.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
@import 'tailwindcss';
@import 'codemirror/lib/codemirror.css';
@import 'codemirror/theme/material.css';
@import '../resources/css/vendors/codemirror.css';
@import '../resources/css/ui.css';
@import '../resources/css/core/utilities.css';
@import '../resources/css/elements/tables.css';
Expand Down
2 changes: 1 addition & 1 deletion resources/js/stories/CodeEditor.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const _ModeSelection: Story = {
const mode = ref('javascript');
return { code, mode };
},
template: `<CodeEditor v-model="code" :mode="mode" allow-mode-selection @update:mode="mode = $event" /><PortalTargets />`,
template: `<CodeEditor v-model="code" :mode="mode" :allow-mode-selection="false" @update:mode="mode = $event" /><PortalTargets />`,
}),
};

Expand Down
8 changes: 1 addition & 7 deletions resources/js/stories/docs/CodeEditor.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ import * as CodeEditorStories from '../CodeEditor.stories';
# CodeEditor
A powerful code editor component powered by CodeMirror. Supports syntax highlighting for multiple languages, line numbers, line wrapping, and keyboard shortcuts.

Docs coming soon.

{/* Todo

<Canvas of={CodeEditorStories._DocsIntro} sourceState={'shown'} />

## Modes
Expand All @@ -25,6 +21,4 @@ Disable line numbers by setting the `line-numbers` prop to `false`. This can be
<Canvas of={CodeEditorStories._NoLineNumbers} sourceState={'shown'} />

## Arguments
<ArgTypes of={CodeEditorStories} />

*/}
<ArgTypes of={CodeEditorStories} />