Skip to content

Conversation

@duncanmcclean
Copy link
Member

This pull request aims to workaround the "Maximum recursive updates exceeded" error from Floating Vue's v-tooltip directive.

While there is an open issue on the floating-vue repository, it's been open for 1.5 years and the last release was tagged nearly 2 years ago so I'm not confident it'll be fixed soon.

Workaround

Inspired by Akryum/floating-vue#1005 (comment), I've created a custom v-tooltip directive which works slightly differently to the floating-vue one.

Instead of mounting a component separately per v-tooltip directive, we mount the Tooltips component once and re-use it. We still use floating-vue's VTooltip component internally for positioning and animations, but with a single shared instance rather than one per directive. This works around the recursive updates error and may help with performance too.


Fixes #13591

@duncanmcclean duncanmcclean changed the title [6.x] Avoid [6.x] Avoid "Maximum recursive updates exceeded" error from tooltips Jan 20, 2026
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're no longer using FloatingVue now, remove it.

@duncanmcclean
Copy link
Member Author

We're still using the VTooltip component it provides, just not the directive (that's the problematic bit).

@jasonvarga
Copy link
Member

jasonvarga commented Jan 21, 2026

Cool it would help if I looked beyond the first line of the diff. 😬 Or read the entire description. My bad.

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It mostly works but something is glitchy.

Try hovering over the Statamic logo in the header. It works great on master but not on this branch.

CleanShot.2026-01-21.at.10.49.22.mp4

@duncanmcclean
Copy link
Member Author

Just pushed up a fix for the logo tooltip. I think it had something to do with it being on the edge of the viewport. Let me know what you think.

CleanShot 2026-01-22 at 00 34 05

@jasonvarga jasonvarga merged commit 2e805aa into master Jan 22, 2026
11 checks passed
@jasonvarga jasonvarga deleted the tooltips branch January 22, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[6.x] Tooltip breaks edit page: Maximum recursive updates exceeded when editing entries with many nested replicator sets

3 participants