[6.x] Avoid localizing time fields in modifiers#13795
Closed
duncanmcclean wants to merge 2 commits into6.xfrom
Closed
[6.x] Avoid localizing time fields in modifiers#13795duncanmcclean wants to merge 2 commits into6.xfrom
duncanmcclean wants to merge 2 commits into6.xfrom
Conversation
Member
|
I don't really want to start augmenting it to a new thing. I feel like that'll cause even more headaches elsewhere. I'll put some more thoughts in the issue itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We started localizing dates passed to modifiers in #11409 as part of wider timezone improvements.
It's great for Date fields, where the date is stored in
UTC, but should be displayed in a different timezone, likeAmerica/New_York.However, it doesn't work for Time fields, which are stored as simple strings and don't need to be converted. This PR ensures they don't get converted.
Fixes #13766