Adjust length of form handle column in form submission table#395
Merged
ryanmitchell merged 2 commits intostatamic:masterfrom Feb 11, 2025
Merged
Conversation
…h has form handle in forms table
Contributor
|
Thanks @Lenitr ! I mad a small tweak but this looks like a sensible change. |
Contributor
Author
Ah I see, that defaults to 255. Thanks, I'll keep that in mind for the future 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue while migrating form submissions from files to eloquent.
Some of the handles of my forms are longer than 30 characters, so i ran into an exception because there's currently a max length of 30 on the form column in the form submissions table.
In the forms table, this column has 255 characters. Not sure why the discrepancy is there (maybe because of the index on the column?)
I fixed my migration by adjusting the migration file for submissions like I did below.