Skip to content

Adjust length of form handle column in form submission table#395

Merged
ryanmitchell merged 2 commits intostatamic:masterfrom
Lenitr:feature/fix-form-submissions-migration
Feb 11, 2025
Merged

Adjust length of form handle column in form submission table#395
ryanmitchell merged 2 commits intostatamic:masterfrom
Lenitr:feature/fix-form-submissions-migration

Conversation

@Lenitr
Copy link
Contributor

@Lenitr Lenitr commented Feb 11, 2025

I ran into an issue while migrating form submissions from files to eloquent.

Some of the handles of my forms are longer than 30 characters, so i ran into an exception because there's currently a max length of 30 on the form column in the form submissions table.
In the forms table, this column has 255 characters. Not sure why the discrepancy is there (maybe because of the index on the column?)

I fixed my migration by adjusting the migration file for submissions like I did below.

@ryanmitchell
Copy link
Contributor

Thanks @Lenitr ! I mad a small tweak but this looks like a sensible change.

@ryanmitchell ryanmitchell merged commit 2ec2d38 into statamic:master Feb 11, 2025
13 checks passed
@Lenitr
Copy link
Contributor Author

Lenitr commented Feb 11, 2025

Thanks @Lenitr ! I mad a small tweak but this looks like a sensible change.

Ah I see, that defaults to 255. Thanks, I'll keep that in mind for the future 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants