[2.x] UI Updates #116
Merged
[2.x] UI Updates #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure any classes we're using in the importer addon don't disapper with updates to core.
- The group fieldtype no longer uses the config layout, which we want in our context. - We also don't need its additional padding, borders, full screen mode. So... I've created a new import_destination fieldtype which extends the Group fieldtype, just with a custom Vue component.
Member
Author
|
Failing tests will be fixed once statamic/cms#12918 has been tagged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the UI of the Importer addon, as well as converting everything to Vue 3 and Inertia.