Refactor XML item parsing in Xml source to use XMLReader#99
Merged
duncanmcclean merged 2 commits intostatamic:mainfrom Apr 7, 2025
Merged
Refactor XML item parsing in Xml source to use XMLReader#99duncanmcclean merged 2 commits intostatamic:mainfrom
duncanmcclean merged 2 commits intostatamic:mainfrom
Conversation
… performance and memory efficiency
duncanmcclean
approved these changes
Apr 7, 2025
Member
duncanmcclean
left a comment
duncanmcclean
left a comment
There was a problem hiding this comment.
This is much faster, thanks! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize XML Processing with XMLReader
Replaces
simplexml_load_filewithXMLReaderfor more memory-efficient XML processing. This change allows the importer to process XML files in a streaming fashion instead of loading the entire file into memory at once.The functionality remains the same, but the implementation is now more scalable for large XML files.