Context should be created on save #22#23
Open
duleorlovic wants to merge 1 commit intostate-machines:masterfrom
Open
Context should be created on save #22#23duleorlovic wants to merge 1 commit intostate-machines:masterfrom
duleorlovic wants to merge 1 commit intostate-machines:masterfrom
Conversation
It seems that context is evaluated on `.new` instead of `.save`
|
@seuros could we get a review of this as well? This would fix a MonkeyPatch that we have been using for a while. |
|
Our monkeypatch is changing this line from which it appears this PR is trying to do in a slightly different way? Perhaps either / both approaches would work, but getting this fixed would be amazing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that context is evaluated on
.newinstead of.save