fix: use RunMut for create/update commands that don't support --json#3
Merged
joshpollara merged 2 commits intomainfrom Mar 19, 2026
Merged
fix: use RunMut for create/update commands that don't support --json#3joshpollara merged 2 commits intomainfrom
joshpollara merged 2 commits intomainfrom
Conversation
RunJSONMut auto-appends --json to every command, but many flyctl subcommands (create, update, attach) don't support that flag, causing "unknown flag: --json" errors. Switch these to RunMut and read back state via a subsequent RunJSON call (list/status), matching the pattern ip_address_resource.go already uses correctly. Also fixes double --json in redis and tigris Read/Update methods where manual --json was added on top of RunJSON's automatic --json. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These became unused after switching mpg_attachment Create to RunMut. Fixes golangci-lint unused error. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunJSONMuttoRunMutfor flyctl subcommands that don't support--json(create, update, attach)RunJSONwith list/status commands (same patternip_address_resource.goalready uses)--jsonbug in redis and tigris Read methods where manual--jsonwas added on top ofRunJSON's automatic--jsonTest plan
go build ./...compiles cleanlygo test ./...— all tests passterraform applywithfly_mpg_clusterresource creates successfully🤖 Generated with Claude Code