You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 25, 2024. It is now read-only.
make the "layout" of the main app more customizable, or rather - achieve bigger control over the pieces that are rendered without a lot of conditional rendering tightly couple to context etc
this allows us to render (in the future) <WebExtension/> that eg. doesn't depend on Monocao anyhow or doesn't know anything about embed mode etc
remove dependency on SCSS to make it easier to bundle <WebExtension/> and also to migrate closer to a single source of truth for styling (previously we were mixing SCSS with Chakra)
In general, to review this PR it might be the easiest to just follow its commits. Most are self-contained refactoring pieces, with some minor bug fixes at the end.
I'm not super fond of some of those "customizable" points here - perhaps this could be structured in a better way. I feel though that the current shape of the code is manageable and we could always refactor stuff later. If you have any general thoughts on composition patterns for problems like this - I'm happy to discuss different tradeoffs etc.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
I think this restructuring makes sense. And from what I can test at the preview deploy, it also looks to be working. And the only failing test is fixed upstream. So LGTM 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![stately-github[bot]](https://avatars.githubusercontent.com/in/155057?s=60&v=4){kind=small}
mellson
left a comment
Goals of this PR:
<WebExtension/>that eg. doesn't depend on Monocao anyhow or doesn't know anything about embed mode etc<WebExtension/>and also to migrate closer to a single source of truth for styling (previously we were mixing SCSS with Chakra)In general, to review this PR it might be the easiest to just follow its commits. Most are self-contained refactoring pieces, with some minor bug fixes at the end.
I'm not super fond of some of those "customizable" points here - perhaps this could be structured in a better way. I feel though that the current shape of the code is manageable and we could always refactor stuff later. If you have any general thoughts on composition patterns for problems like this - I'm happy to discuss different tradeoffs etc.