Fix bug in morph relation of menu item

Author: sten

src/Form/Fields/Types/LinkableMenuItemType.php

@@ -49,17 +49,6 @@ public function searchResultLimit(int $limit): static
         return $this;
     }
 
-    public function getSelectField(): Select
-    {
-        return Select::make('linkable_id')
-            ->label(flexiblePagesTrans('menu_items.form.linkable_item_lbl'))
-            ->searchable()
-            ->getSearchResultsUsing(fn (string $search): array => $this->getSearchResults($search))
-            ->getOptionLabelUsing(fn ($value): ?string => $this->getOptionLabel($value))
-            ->required()
-            ->helperText($this->getHelperText());
-    }
-
     public function getSearchResults(string $search): array
     {
         $modelClass = $this->model;

src/Form/Forms/MenuItemForm.php

@@ -168,7 +168,7 @@ protected static function getLinkableField(): Select
                 $type = static::getTypeByAlias($linkType);
 
                 if ($type && $type->isModelType() && $state) {
-                    $set(static::FIELD_LINKABLE_TYPE, $type->getModel());
+                    $set(static::FIELD_LINKABLE_TYPE, $type->getAlias());
                 }
             });
     }
@@ -270,6 +270,9 @@ protected static function getModelLabelFromResource(string $modelClass): string
         return class_basename($modelClass);
     }
 
+    /**
+     * @return AbstractMenuItemType[]
+     */
     protected static function getTypes(): array
     {
         if (static::$types === null) {

src/Models/MenuItem.php

@@ -111,9 +111,4 @@ public function isVisible(): bool
     {
         return $this->is_visible;
     }
-
-    public function getTitleAttribute(): string
-    {
-        return $this->getDisplayLabel();
-    }
 }

src/Resources/MenuResource/Pages/ManageMenuItems.php

@@ -126,7 +126,7 @@ protected function getMenuItemTypeDescription(MenuItem $record): string
     {
         if ($record->linkable_type && $record->linkable) {
             // Get model label from Filament resource if available
-            $modelLabel = $this->getModelLabelFromResource($record->linkable_type);
+            $modelLabel = $this->getModelLabelFromResource($record->linkable::class);
 
             return flexiblePagesTrans('menu_items.tree.linked_to').' '.$modelLabel;
         } elseif ($record->url) {
@@ -194,7 +194,7 @@ public function getTreeRecordIcon(?\Illuminate\Database\Eloquent\Model $record =
 
         // Return appropriate icon based on type
         if ($record->linkable_type && $record->linkable) {
-            return $this->getModelIconFromResource($record->linkable_type) ?: 'heroicon-o-link';
+            return $this->getModelIconFromResource($record->linkable::class) ?: 'heroicon-o-link';
         }
 
         if ($record->url) {