Improve bulk delete action

Author: sten

resources/lang/en/filament-flexible-content-block-pages.php

@@ -17,8 +17,10 @@
             'created_at_col' => 'Created at',
         ],
         'notifications' => [
-            'used_in_menu' => 'This page is used in the ":menu" menu, in item :menu_item. Please update the menu first and then try deleting this page again.',
-            'used_in_menu_bulk' => 'Page ":page" is used in the ":menu" menu, in item :menu_item. Please update the menu first and then try deleting this page again.',
+            'used_in_menu' => 'This is used in the ":menu" menu, in item :menu_item. Please update the menu first and then delete this again.',
+            'used_in_menu_bulk' => 'Some items are used in menus. Please update the menus first and then delete these items again.',
+            'page_referenced_by_menu_item' => '":page" (referenced by :menu in :menu_item)',
+            'bulk_delete_successful' => ':count items deleted.',
         ],
 
     ],

resources/lang/nl/filament-flexible-content-block-pages.php

@@ -17,8 +17,10 @@
             'created_at_col' => 'Aangemaakt op',
         ],
         'notifications' => [
-            'used_in_menu' => 'Deze pagina wordt in het ":menu" menu gebruikt, in item :menu_item. Gelieve eerst het menu aan te passen en dan deze pagina opnieuw te verwijderen.',
-            'used_in_menu_bulk' => 'Pagina ":page" wordt in het ":menu" menu gebruikt, in item :menu_item. Gelieve eerst het menu aan te passen en dan deze pagina opnieuw te verwijderen.',
+            'used_in_menu' => 'Dit wordt in het ":menu" menu gebruikt, in item :menu_item. Gelieve eerst het menu aan te passen en dan dit opnieuw te verwijderen.',
+            'used_in_menu_bulk' => 'Sommige items worden in menu\'s gebruikt. Gelieve eerst de menu\'s aan te passen en dan deze itemss opnieuw te verwijderen.',
+            'page_referenced_by_menu_item' => '":page" (gerefereerd door :menu in :menu_item)',
+            'bulk_delete_successful' => ':count items verwijderd.',
         ],
     ],
     'redirects' => [

src/Actions/LinkedToMenuItemBulkDeleteAction.php

@@ -7,6 +7,7 @@
 use Filament\Tables\Actions\DeleteBulkAction;
 use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Support\HtmlString;
 use Statikbe\FilamentFlexibleContentBlockPages\Models\Contracts\HasMenuLabel;
 use Statikbe\FilamentFlexibleContentBlockPages\Models\MenuItem;
 
@@ -20,33 +21,49 @@ public function setUp(): void
         parent::setUp();
 
         $this->action(function (Collection $records, LinkedToMenuItemBulkDeleteAction $action) {
-            $usedInMenu = false;
+            $referencedPages = [];
+            $deletablePages = [];
+
             foreach ($records as $record) {
                 /** @var Model&HasMenuLabel $record */
                 // Prevent deletion if the page is referenced by a menu item
                 /** @var ?MenuItem $menuItem */
                 $menuItem = $record->menuItem;
 
                 if ($menuItem) {
-                    $usedInMenu = true;
-
-                    Notification::make()
-                        ->title(flexiblePagesTrans('pages.notifications.used_in_menu_bulk', [
-                            'page' => $record->getMenuLabel(),
-                            'menu' => $menuItem->menu->name,
-                            'menu_item' => $menuItem->getDisplayLabel(),
-                        ]))
-                        ->danger()
-                        ->duration(12000)
-                        ->send();
+                    $referencedPages[] = $record;
+                } else {
+                    $deletablePages[] = $record;
                 }
             }
 
-            if ($usedInMenu) {
-                $action->failure();
+            if (! empty($referencedPages)) {
+                $pageNames = collect($referencedPages)->map(function (Model&HasMenuLabel $page) {
+                    return '<li>'.
+                        flexiblePagesTrans('pages.notifications.page_referenced_by_menu_item', [
+                            'page' => $page->getMenuLabel(),
+                            'menu' => $page->menuItem->menu->name,
+                            'menu_item' => $page->menuItem->getDisplayLabel(),
+                        ])
+                        .'</li>';
+                })->join('');
+
+                Notification::make()
+                    ->title(flexiblePagesTrans('pages.notifications.used_in_menu_bulk'))
+                    ->body(new HtmlString("<ul>$pageNames</ul>"))
+                    ->danger()
+                    ->duration(12000)
+                    ->send();
             }
-            else {
-                $this->process(static fn (Collection $records) => $records->each(fn (Model&HasMenuLabel $record) => $record->delete()));
+
+            if (! empty($deletablePages)) {
+                collect($deletablePages)->each(fn (Model&HasMenuLabel $record) => $record->delete());
+
+                Notification::make()
+                    ->title(flexiblePagesTrans('pages.notifications.bulk_delete_successful', ['count' => count($deletablePages)]))
+                    ->success()
+                    ->send();
+
                 $action->success();
             }
         });

src/Resources/PageResource.php

@@ -168,7 +168,7 @@ protected static function getAdvancedTabFields(): array
                 ->searchable(['title', 'code', 'slug', 'intro']);
         }
 
-        if (!empty($gridFields)) {
+        if (! empty($gridFields)) {
             $fields[] = Grid::make()->schema($gridFields);
         }
 
@@ -198,7 +198,7 @@ public static function table(Table $table): Table
                 LinkedToMenuItemBulkDeleteAction::make(),
             ])
             ->recordUrl(
-                fn($record): string => static::getUrl('edit', ['record' => $record])
+                fn ($record): string => static::getUrl('edit', ['record' => $record])
             )
             ->modifyQueryUsing(function (Builder $query) {
                 $query->with(['menuItem']);