Call To Action: now has the possibility of adding icons to label#57
Call To Action: now has the possibility of adding icons to label#57torresdistrib wants to merge 1 commit intostatikbe:mainfrom
Conversation
|
@torresdistrib Thanks for the icon implementation! Certainly useful. To merge this, we will need to make sure it is backward compatible and the feature can be disabled. Do you have time to contribute this? |
|
I'm glad you find it useful! I didn't test for it, but you're correct; it should be backward compatible, and I believe it should be easy enough to do (given my available time and limited skills). I agree with you; it's a very niche area of knowledge :) Nonetheless, it's easily accessible. My main concern is around the naming of the classes, as they strongly correlate to the FontAwesome version you are running (and whether you have the Pro version or not). Not to mention the variants of the same icon that you can have. I simply can't say that I understand FontAwesome well enough to build an automatic dropdown that accounts for all the versions, etc. Let me know if that's a deal breaker or if you want me just to check backward compatibility. All the best |
Description
Call To Action: now has the possibility of adding icons to label
Reason for this change
I use a lot of labels with icons all the time, this makes the job way easier to manage.
I think this PR is complete, I tested it works just fine for me.
I hope you also find it usefull, feel free to change anything I may messed up
On Admin:

FrontEnd:

Cheers
JT