Merged
Conversation
Co-authored-by: pawbu <pawbu@users.noreply.github.com>
|
pawbu
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File System Adapters
Splitting the local storage module into three separate modules for the different file locations. Datastore files, working files and input files. These can be access through a FileSystemAdapter that is specific to a datastore. Called this module fs/ for filesystem to match how we usually do db/ for database, and made a local storage implementation of the File System protocol.
I think the splitting of the file locations allowed for way better naming which is a nice bonus.
Planning to make protocols for each of the directories to improve testing as well, and to use the adapters in a more sensible way, but this branch is getting quite heavy already so I opted to change as little as possible to introduce the adapters.
Next steps for these adapters:
But these tasks are represented by an issue under the same parent issue as this.