Skip to content

file_system_adapters: bugfix #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielElisenberg merged 1 commit into from
Oct 21, 2025
Merged

file_system_adapters: bugfix #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions job_executor/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import logging
import time
from multiprocessing import Queue
from pathlib import Path

from job_executor.adapter import datastore_api, local_storage
from job_executor.adapter import datastore_api
from job_executor.adapter.datastore_api.models import JobStatus
from job_executor.adapter.fs import LocalStorageAdapter
from job_executor.common.exceptions import StartupException
from job_executor.config import environment
from job_executor.config.log import initialize_logging_thread, setup_logging
Expand All @@ -16,8 +18,9 @@

def initialize_app() -> None:
try:
local_storage = LocalStorageAdapter(Path(environment.datastore_dir))
rollback.fix_interrupted_jobs()
if local_storage.temporary_backup_exists():
if local_storage.datastore_dir.temporary_backup_exists():
raise StartupException("tmp directory exists")
except Exception as e:
raise StartupException("Exception when initializing") from e
Expand All @@ -26,6 +29,7 @@ def initialize_app() -> None:
def handle_jobs(manager: Manager, logging_queue: Queue) -> None:
job_query_result = datastore_api.query_for_jobs()
manager.clean_up_after_dead_workers()
local_storage = LocalStorageAdapter(Path(environment.datastore_dir))
if job_query_result.available_jobs_count:
logger.info(
f"Found {len(job_query_result.queued_worker_jobs)}"
Expand All @@ -35,7 +39,7 @@ def handle_jobs(manager: Manager, logging_queue: Queue) -> None:
)

for job in job_query_result.queued_worker_jobs:
job_size = local_storage.get_input_tar_size_in_bytes(
job_size = local_storage.input_dir.get_importable_tar_size_in_bytes(
job.parameters.target
)
if job_size == 0:
Expand Down