Merged
Conversation
Collaborator
DanielElisenberg
commented
Oct 24, 2025
DanielElisenberg
commented
- Add datastore_rdn to job models, for now we are just injecting the rdn from environment
- Use datastore specific local storage adapters
- Getting datastore directory from datastore-api, currently just hard coding the root dir from environment until datastore-api endpoints are implemented
- Using the job specific local storage adapters everywhere. Lots of room for improvement here, but kept it super simple for now to avoid too many changes. Will definitely clean this up down the line.
- Updated tests
Closed
|
linnbjornerud
approved these changes
Oct 24, 2025
Contributor
linnbjornerud
left a comment
linnbjornerud
left a comment
There was a problem hiding this comment.
I think this looks very good 👍🏻
| response = execute_request("GET", request_url, True) | ||
| return [Job(**job) for job in response.json()] | ||
| return [ | ||
| Job.model_validate({"datastoreRdn": environment.datastore_rdn, **job}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.