use_multi_tenancy_endpoints: use datastore endpoint for directory#207
Merged
DanielElisenberg merged 1 commit intomainfrom Oct 29, 2025
Merged
use_multi_tenancy_endpoints: use datastore endpoint for directory#207DanielElisenberg merged 1 commit intomainfrom
DanielElisenberg merged 1 commit intomainfrom
Conversation
|
Contributor
linnbjornerud
left a comment
linnbjornerud
left a comment
There was a problem hiding this comment.
environment.datastore_dir is still used in app.py and rollback.py. Is this intentional?
DATASTORE_RDN and DATASTORE_DIR from env is used in most tests - but I suppose you have a bigger plan for cleaning up all the tests later?
Collaborator
Author
Yes after this there will be a PR moving over all of this. Just wanted the work we did yesterday + unit tests merged first
Yes 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the new datastore info endpoint for deciding datastore directory to work on