Skip to content

[MIM-2157] Mim 2157 bpi calculator adjustments#3138

Merged
johnnadeluy merged 6 commits intodevelopfrom
MIM-2157_bpi_calculator_adjustments
Feb 10, 2025
Merged

[MIM-2157] Mim 2157 bpi calculator adjustments#3138
johnnadeluy merged 6 commits intodevelopfrom
MIM-2157_bpi_calculator_adjustments

Conversation

@johnnadeluy
Copy link
Contributor

@johnnadeluy johnnadeluy commented Feb 7, 2025

  • Adds space between amount and valute for results
  • Fixes validation for invalid start- and end index
    • Move to calculatorUtils and implement in bpi calculator service
  • Adds validation for year depending on region pick; most regions have data all the way back to 2005 and the remaining two are the only ones dating back to 1992

Jira Issues!

Link to ticket: MIM-2157

@github-actions github-actions bot changed the title Mim 2157 bpi calculator adjustments [MIM-2157] Mim 2157 bpi calculator adjustments Feb 7, 2025

useEffect(() => {
// Only options "TOTAL = The whole country" and "001 = Oslo including Bærum" has data dating back to 1992
if (region.value.id === 'TOTAL' || region.value.id === '001') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

region 005 (Akershus uten Bærum) har også tall fra 1992

@sonarqubecloud
Copy link

Copy link
Contributor

@ssb-cgn ssb-cgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnnadeluy johnnadeluy merged commit b28b40f into develop Feb 10, 2025
10 of 11 checks passed
@johnnadeluy johnnadeluy deleted the MIM-2157_bpi_calculator_adjustments branch February 11, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants