[MIM-2210] Mim 2210 tweaks statistics#3155
Merged
johnnadeluy merged 5 commits intodevelopfrom Feb 25, 2025
Merged
Conversation
github-actions
bot
changed the title
ssb-cgn
reviewed
Feb 25, 2025
|
|
||
| return render('site/parts/statisticDescription/statisticDescription', props, req, { | ||
| body: `<section id="om-statistikken" class="xp-part statistic-description container-fluid"></section>`, | ||
| body: `<section id="om-statistikken" class="xp-part statistic-description container-fluid p-0"></section>`, |
Contributor
There was a problem hiding this comment.
Istedenfor å legge på p-0 kan du fjerne container-fluid, har ikke det på de andre 3 elementene på ny statistikkmal, så er bare en forglemmelse at den ble med på denne :)
ssb-cgn
reviewed
Feb 25, 2025
| .ssb-tag.active { | ||
| background: $ssb-green-4; | ||
| color: $ssb-white; | ||
| .ssb-tag { |
Contributor
There was a problem hiding this comment.
Burde heller endre komponenten Tag i komponentbibilioteket. Hvis man der bruker outline istedenfor border for &:active så tror jeg problemet forsvinner.
…tline for tags Use container instead of container-fluid instead MIM-2210
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issues!
Link to ticket: MIM-2210