Merged
Conversation
Contributor
|
Hey @martin-mfg, thanks for the pull request will take a look. The v1 should be automatically moved by our action to the latest tag. See https://github.com/rickstaa/action-create-tag/tags for an example. For some reason the action not triggered. 🤔 |
Contributor
|
I think it was because the tag was created in the Github UI in my phone. I moved the tag. If you can update the pr to use v1 we can merge the PR. 🙏 |
Contributor
|
Thanks again @martin-mfg. 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jobs->build, there's no need to mention them at root level toopunycodemodule is deprecated. Please use a userland alternative instead.". This seems to be an issue in setup-node.