Invalidate boundary when converting HashList to HashArray in HashSeq#150
Merged
Invalidate boundary when converting HashList to HashArray in HashSeq#150
Conversation
Cache layout is equivalent, but when using readSszBytes the boundary has to be cleared first to cover the case where the resize does not incrementally fill up the list to the full capacity before converting. Also move the boundary cache invalidation from types.nim to codec.nim.
etan-status
commented
Feb 12, 2026
Comment on lines
229
to
+231
| # Unconditionally trigger small, O(1) updates to handle when the list | ||
| # shrinks without otherwise changing. | ||
| val.clearCaches(0) | ||
| val.clearCaches(max(val.len - 1, 0)) | ||
| # resizes without otherwise changing. | ||
| val.clearCaches(max(min(val.len, oldDataLen) - 1, 0)) |
Contributor
Author
There was a problem hiding this comment.
This is the one that we were missing. The shrinking to a different depth was fine, but the followup re-growth hit the stale cache. Clearing the boundary at oldDataLen fixes that.
Contributor
Author
Like, here the codec with more context.
For shrinking the logic was already in place. For growing, it cleared the second boundary (within the new uninitSentinel area) rather than the boundary between retained and new data. |
Isiah-n-paul85
approved these changes
Feb 14, 2026
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache layout is equivalent, but when using readSszBytes the boundary has to be cleared first to cover the case where the resize does not incrementally fill up the list to the full capacity before converting. Also move the boundary cache invalidation from types.nim to codec.nim.