-
Notifications
You must be signed in to change notification settings - Fork 143
drop logsBloom support #3292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop logsBloom support #3292
Conversation
Needs #3290 |
Merged |
isn't this on the "declined for inclusion" list? https://eips.ethereum.org/EIPS/eip-7607#declined-for-inclusion |
We are not removing bloom filters from the execution block. We are just not storing it in receipts, as we don't need to
We earlier needed bloom filter in receipts to serve them in p2p layer or rpc, well IMO didn't make sense to store the bloom filters back then also. But now the requirement for p2p layer gone, doesn't make sense a lot more to keep storing them, |
This PR removes the
logsBloom
field from stored receipts. The bloom filter can be recomputed when needed (e.g., for networking or RPC), so storing it in the database is unnecessary.None of the major clients (Geth, Nethermind, Besu, Erigon) store bloom filters in their receipt DB. However, the networking spec still requires
logsBloom
to be included in receipt responses. As a result, serving peers regenerate ~530GB of bloom data (2.3B txs × 256 bytes) per sync — which is verified and then discarded by the syncing peer.This is an unnecessary bandwidth and I/O cost.
Historically, bloom filters were included in receipts to support log filtering over the P2P layer. With
eth/69
removing that requirement, there's no longer a reason to persist this field. This aligns with real-world client behavior and reduces resource usage.We still comply with the protocol by computing and returning
logsBloom
on demand when serving receipts. We are only skipping its storage on disk.Since this is a pre-release client, we're free to adjust the receipt schema without impacting compatibility.
Advantages:
TODO
master