Skip to content

portal: pass list item instead of list #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

portal: pass list item instead of list #3414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion portal/tools/eth_data_exporter/parser.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ proc fromJson*(n: JsonNode, name: string, x: var seq[Authorization]) =
let node = n[name]
for v in node:
x = newSeqOfCap[Authorization](node.len)
x.add parseAuth(node)
x.add parseAuth(v)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code still doesn't look right. Why does the seq get recreated on each iteration of the loop?
x = newSeqOfCap[Authorization](node.len)

I didn't write this code so perhaps @kdeme has a better idea?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know either, I did not write it. It got copied over from premix before that got removed


proc parseBlockHeader*(n: JsonNode): Header =
n.fromJson "parentHash", result.parentHash
Expand Down
Loading