Skip to content

Commit 5b7a8ba

Browse files
authored
reorder checks (#7078)
1 parent 9e68503 commit 5b7a8ba

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

beacon_chain/sync/request_manager.nim

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -284,14 +284,14 @@ proc fetchBlobsFromNetwork(self: RequestManager,
284284
if blobs.isOk:
285285
var ublobs = blobs.get().asSeq()
286286
ublobs.sort(cmpSidecarIndexes)
287-
if not checkResponseSanity(idList, ublobs):
288-
debug "Response to blobs by root have erroneous block root",
287+
if not checkResponseSubset(idList, ublobs):
288+
debug "Response to blobs by root is not a subset",
289289
peer = peer, blobs = shortLog(idList), ublobs = len(ublobs)
290290
peer.updateScore(PeerScoreBadResponse)
291291
return
292292

293-
if not checkResponseSubset(idList, ublobs):
294-
debug "Response to blobs by root is not a subset",
293+
if not checkResponseSanity(idList, ublobs):
294+
debug "Response to blobs by root have erroneous block root",
295295
peer = peer, blobs = shortLog(idList), ublobs = len(ublobs)
296296
peer.updateScore(PeerScoreBadResponse)
297297
return
@@ -376,14 +376,14 @@ proc fetchDataColumnsFromNetwork(rman: RequestManager,
376376
if columns.isOk:
377377
var ucolumns = columns.get().asSeq()
378378
ucolumns.sort(cmpSidecarIndexes)
379-
if not checkResponseSanity(colIdList, ucolumns):
380-
debug "Response to columns by root have erroneous block root",
379+
if not checkResponseSubset(colIdList, ucolumns):
380+
debug "Response to columns by root is not a subset",
381381
peer = peer, columns = shortLog(colIdList), ucolumns = len(ucolumns)
382382
peer.updateScore(PeerScoreBadResponse)
383383
return
384384

385-
if not checkResponseSubset(colIdList, ucolumns):
386-
debug "Response to columns by root is not a subset",
385+
if not checkResponseSanity(colIdList, ucolumns):
386+
debug "Response to columns by root have erroneous block root",
387387
peer = peer, columns = shortLog(colIdList), ucolumns = len(ucolumns)
388388
peer.updateScore(PeerScoreBadResponse)
389389
return

0 commit comments

Comments
 (0)