Verify chronos/TokenBucket updated replenish algorithm#7436
Open
NagyZoltanPeter wants to merge 1 commit intounstablefrom
Open
Verify chronos/TokenBucket updated replenish algorithm#7436NagyZoltanPeter wants to merge 1 commit intounstablefrom
NagyZoltanPeter wants to merge 1 commit intounstablefrom
Conversation
…updated to wokring branch
siddarthkay
force-pushed
the
unstable
branch
from
6c84d01 to
b118196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intended to verify nim-chronos updated TokenBucket compatibility with eth2.
The nim-chronos vendor submodule has been updated to a working branch chore-token-bucket-unification.
With status-im/nim-chronos#582 TokenBucket is modified:
fixed, to handle initial lastUpdate correctly
Updated replenish algorithm to utilize available tokens better and serve small bursts that spread in time.
no braking interface changes
This PR is not meant to merge as is. Changes can only take effect with vendor bumps after nim-chronos' PR is accepted and merged.