Switch to the intops-powered version of stint.#7936
Closed
Conversation
|
Pull requests to the |
|
Pull requests to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to status-im/nimbus-eth1#3956, this PR introduces a new dependency (intops) and updates stint to point to the forked version that uses intops internally.
Since nimbus-eth2 doesn't use bncurve, only stint is affected.
Whether the benchmarks should be verified and how to do that are open questions but the tests to pass locally and so far no performance regression was observed in benchmarks for nimbus-eth1, stint, or bncurve.