Conversation
agnxsh
reviewed
Feb 11, 2026
| var checks = @roots | ||
| if len(envelopes) > len(roots): | ||
| return false | ||
| for envelope in envelopes: |
Contributor
There was a problem hiding this comment.
would it be useful to make envelopes a HashSet? how frequently can rman for enevelopes get triggered for missing envelopes? also mostly depends on the max missing envelopes
agnxsh
reviewed
Feb 11, 2026
tersec
reviewed
Feb 12, 2026
tersec
reviewed
Feb 12, 2026
tersec
reviewed
Feb 12, 2026
| rman.dataColumnLoopFuture = | ||
| rman.requestManagerDataColumnLoop() | ||
|
|
||
| proc switchToEnvelopeLoop*(self: var RequestManager) = |
Contributor
There was a problem hiding this comment.
switchToColumnLoop is named as such because it's switching from a blob loop. But what is this switching from? It's not really switching at all.
Contributor
There was a problem hiding this comment.
exactly, it's not really a switch, you can just name it as startEnvelopeLoop, or just another overload of start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.