remove pre-Electra block production, attestation handling leftovers#7959
Open
arnetheduck wants to merge 7 commits intounstablefrom
Open
remove pre-Electra block production, attestation handling leftovers#7959arnetheduck wants to merge 7 commits intounstablefrom
arnetheduck wants to merge 7 commits intounstablefrom
Conversation
#7550 removed the ability to pack pre-Electra attestations in the attestation pool effectively removing the ability to create meaningful pre-Electra blocks - as such, there is little point in keeping the rest of the associated infrastructure around. * refactor attestation pool to further remove phase0-based logic * drop single-vote attestations after creating full committee aggregate * simplify attestation cache key for block production (no need to include slot twice) * avoid the use of `AttestationData` in `AttestationEntry` since they are no longer logically related (the latter is partitioned by committee index, the former is not) * restore updates of last-voted-epoch for post-electra attestations and ignore duplicates based on it * fix missing log data in "Dropping" logs (`logScope` does not work in generic functions) (fixes #7795) * remove handlers/validators for pre-Electra attestation/aggregate gossip * update gossip tests to cover post-Electra attestations * remove pre-electra block production code paths in beacon node * gossip fork checks based on message slot rather than wall time * remove internal routing of on-chain attestation (obviously should never happen)
arnetheduck
changed the title
Contributor
|
Merge conflict in |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7550 removed the ability to pack pre-Electra attestations in the attestation pool effectively removing the ability to create meaningful pre-Electra blocks - as such, there is little point in keeping the rest of the associated infrastructure around.
AttestationDatainAttestationEntrysince they are no longer logically related (the latter is partitioned by committee index, the former is not)logScopedoes not work in generic functions) (fixes Logs flooding with line Dropping aggregate #7795)