Conversation
Following the removal of gossip support for phase0 attestations we can clean up how we iterate over attestations, removing the single-attestation phase0 forms. Also, since the electra network attestation format is a special case of the on-chain format, we can reuse the latter in the iteration helpers for the former, getting rid of the on-chain flag. Finally, we can also avoid some memory allocations by not constructing an in-memory copy of the committee and instead iterate over its indices in-place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the removal of gossip support for phase0 attestations we can clean up how we iterate over attestations, removing the single-attestation phase0 forms.
Also, since the electra network attestation format is a special case of the on-chain format, we can reuse the latter in the iteration helpers for the former, getting rid of the on-chain flag.
Finally, we can also avoid some memory allocations by not constructing an in-memory copy of the committee and instead iterate over its indices in-place.